MAINT: Enforce ruff/flake8-comprehensions rules (C4) #1498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C401 Unnecessary generator (rewrite as a set comprehension)
C402 Unnecessary generator (rewrite as a dict comprehension)
C408 Unnecessary `dict()` call (rewrite as a literal)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
C4rules apply micro-optimisations that do result in faster code locally. However, in most cases, the global speed-up is imperceptible, as often with micro-optimisations. I think the actual purpose is consistent code, not speed, standardising on the most efficient Python construct.These changes are debatable, some maintainers don't like them, as they don't find the resulting code more maintainable or readable. I could disable rules
C401,C403andC408instead.